Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to create a "protocol development" poll? #2785

Open
grctest opened this issue Dec 14, 2024 · 4 comments
Open

Unable to create a "protocol development" poll? #2785

grctest opened this issue Dec 14, 2024 · 4 comments
Assignees
Milestone

Comments

@grctest
Copy link
Contributor

grctest commented Dec 14, 2024

Bug Report

Current behavior

I'm unable to create a poll with the "protocol development" type.

Expected behavior

I'm able to create such a poll.

Steps to reproduce:

Try to broadcast the creation of a protocol development poll.

Gridcoin version

5.4.8.0-leisure

Machine specs

  • OS: Windows 10
  • CPU: i7-6500u
  • RAM: 24GB
  • Disk Type (HD/SSD): HD

Extra information

"ERROR: CreateTransaction: tx size 513705 greater than the standard 100000"

I have 100k+ GRC in one address as required.

My wallet was locked, unlocked for broadcasting the poll creation transaction.

@grctest grctest added the bug label Dec 14, 2024
@gridcoin-community gridcoin-community deleted a comment Dec 14, 2024
@jamescowens
Copy link
Member

I have been in dialogue with @grctest on this. It looks like this is due to small UTXO size, which is causing the transaction to be too large to contain the 100k balance attestation.

@div72
Copy link
Member

div72 commented Dec 14, 2024

Why are balance attestations for polls restricted to a single address only? Allowing multiple addresses allows between ~500(single UTXO for all addresses) to ~2700 UTXOs(single address for all UTXOs), I'd be surprised if 100kGRC does not fit in that case if not spread intentionally.

@jamescowens
Copy link
Member

Cycy did this for simplicity, and it has not been changed. In @grctest's case I think he has his UTXO's spread across many addresses. The logic to choose the best address may not be good. We need to replace this with the general attestation algorithm for votes, which can operate across multiple addresses and choose the largest UTXO's downwards.

@jamescowens jamescowens self-assigned this Dec 14, 2024
@jamescowens jamescowens added this to the Natasha milestone Dec 14, 2024
@jamescowens
Copy link
Member

The PollClaimBuilder class and the corresponding PollClaimValidator class have to be revised. This will have to be keyed on the next mandatory.

@jamescowens jamescowens added mandatory and removed bug labels Dec 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants