From b24e0ae1b5ada797ead8c5765fbb540257b7fb46 Mon Sep 17 00:00:00 2001 From: Abdelsalem Date: Thu, 9 Nov 2023 11:06:31 +0100 Subject: [PATCH 1/2] clear searchbar after selection Signed-off-by: Abdelsalem --- src/components/ElementSearchDialog/element-search-dialog.js | 1 + 1 file changed, 1 insertion(+) diff --git a/src/components/ElementSearchDialog/element-search-dialog.js b/src/components/ElementSearchDialog/element-search-dialog.js index 15586beb..e0537607 100644 --- a/src/components/ElementSearchDialog/element-search-dialog.js +++ b/src/components/ElementSearchDialog/element-search-dialog.js @@ -93,6 +93,7 @@ const ElementSearchDialog = (props) => { if (reason === 'selectOption') { onSelectionChange(newValue); setValue(newValue); + handleClose(); } else { setValue(null); } From 617a58d901f4ddf8895d1b9150ab6f44cb987d70 Mon Sep 17 00:00:00 2001 From: Abdelsalem Date: Thu, 9 Nov 2023 20:06:41 +0100 Subject: [PATCH 2/2] change approch Signed-off-by: Abdelsalem --- src/components/ElementSearchDialog/element-search-dialog.js | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/src/components/ElementSearchDialog/element-search-dialog.js b/src/components/ElementSearchDialog/element-search-dialog.js index e0537607..2bce31f4 100644 --- a/src/components/ElementSearchDialog/element-search-dialog.js +++ b/src/components/ElementSearchDialog/element-search-dialog.js @@ -47,6 +47,11 @@ const ElementSearchDialog = (props) => { } }, [searchTermDisabled, searchTermDisableReason]); + // to reset the value between the dialog closing and opening + useEffect(() => { + setValue((old) => (!open ? null : old)); + }, [open]); + const handleSearchTermChange = (term) => { if (term) { setLoading(true); @@ -93,7 +98,6 @@ const ElementSearchDialog = (props) => { if (reason === 'selectOption') { onSelectionChange(newValue); setValue(newValue); - handleClose(); } else { setValue(null); }