[POC] Report tree - Rich tree view #2379
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: TOURI ANIS <[email protected]>
Meklo
changed the title
anistouri
reviewed
Nov 8, 2024
| @@ -7,16 +7,17 @@ | |||
| "dependencies": { | |||
| "@emotion/react": "^11.11.4", | |||
| "@emotion/styled": "^11.11.5", | |||
| "@gridsuite/commons-ui": "0.70.0", | |||
| "@gridsuite/commons-ui": "file:../commons-ui/gridsuite-commons-ui-0.70.0.tgz", | |||
| @@ -67,7 +67,7 @@ export const QuickSearch: React.FC<QuickSearchProps> = ({ | |||
| value={searchTerm} | |||
| onChange={(event: React.ChangeEvent<HTMLInputElement>) => onChange(event.target.value)} | |||
| onKeyDown={handleKeyDown} | |||
| placeholder={intl.formatMessage({ id: 'searchPlaceholder' })} | |||
| placeholder={intl.formatMessage({ id: 'searchPlaceholderLog' })} | |||
There was a problem hiding this comment.
why do you have this change ?
There was a problem hiding this comment.
I think it's an issue with merging into main
| @@ -1399,7 +1399,8 @@ | |||
| "startStateEstmationError": "An error occurred while launching the state estimation", | |||
| "stateEstimationError": "An error occurred when executing the state estimation", | |||
| "NoFilter": "No filter", | |||
| "searchPlaceholder": "Search in Logs", | |||
| "searchPlaceholder": "Search", | |||
| "searchPlaceholderLog": "Search in Logs", | |||
There was a problem hiding this comment.
Same remark, you shouldn't have these changes
| @@ -1398,7 +1398,8 @@ | |||
| "startStateEstimationError": "Une erreur est survenue lors du lancement de l'estimation d'état", | |||
| "stateEstimationError": "Une erreur est survenue lors de l'exécution de l'estimation d'état", | |||
| "NoFilter": "Aucun filtre", | |||
| "searchPlaceholder": "Rechercher dans les Logs", | |||
| "searchPlaceholder": "Recherche", | |||
| "searchPlaceholderLog": "Rechercher dans les Logs", | |||
There was a problem hiding this comment.
Same remark, you shouldn't have these changes
anistouri
requested changes
Nov 8, 2024
There was a problem hiding this comment.
This commit needs to be removed from this PR "Fix wording in search placeholder"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.