Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Save the column positions #2453

Merged
merged 25 commits into from
Dec 31, 2024
Merged

Save the column positions #2453

merged 25 commits into from
Dec 31, 2024
+125 −189

Conversation

EstherDarkish
Copy link
Contributor

@EstherDarkish EstherDarkish commented Dec 14, 2024 •
edited
Loading

BOUTIER Charly added 3 commits December 14, 2024 01:19
WIP kinda working, but missing a part in the reducer to link notifica…
37b4199 
…tions to the Model.

Signed-off-by: BOUTIER Charly <[email protected]>
WIP Almost done, still needs the reordering part.
de79d0c 
Signed-off-by: BOUTIER Charly <[email protected]>
Working.
4ee4f37 
Signed-off-by: BOUTIER Charly <[email protected]>
@EstherDarkish EstherDarkish changed the title WIP Save the column positions Save the column positions Dec 15, 2024
@EstherDarkish EstherDarkish mentioned this pull request Dec 15, 2024
Merged
BOUTIER Charly added 2 commits December 15, 2024 15:48
Code cleaning
f70f0c0 
Signed-off-by: BOUTIER Charly <[email protected]>
Code cleaning
07bd1e9 
Signed-off-by: BOUTIER Charly <[email protected]>
BOUTIER Charly and others added 7 commits December 16, 2024 08:23
SlimaneAmar
SlimaneAmar reviewed Dec 17, 2024
View reviewed changes
src/translations/fr.json Outdated Show resolved Hide resolved
src/redux/reducer.ts Outdated Show resolved Hide resolved
src/redux/actions.ts Outdated Show resolved Hide resolved
BOUTIER Charly and others added 5 commits December 17, 2024 17:10
PR Review
b47c5fa 
Signed-off-by: BOUTIER Charly <[email protected]>
PR Review
3190a6d 
Signed-off-by: BOUTIER Charly <[email protected]>
PR Review
dce4b3a 
Signed-off-by: BOUTIER Charly <[email protected]>
Code cleaning : removed the switch branch function and use the reorde…
975e18d 
…r everytime.

Signed-off-by: BOUTIER Charly <[email protected]>
@EstherDarkish
Merge branch 'main' into save_column_positions
c698fdc
SlimaneAmar
SlimaneAmar approved these changes Dec 18, 2024
View reviewed changes
src/components/graph/network-modification-tree-model.ts Outdated Show resolved Hide resolved
src/components/graph/network-modification-tree-model.ts Outdated Show resolved Hide resolved
src/components/network-modification-tree.jsx Outdated Show resolved Hide resolved
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
1.8% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@SlimaneAmar SlimaneAmar merged commit b293d22 into main Dec 31, 2024
5 checks passed
@SlimaneAmar SlimaneAmar deleted the save_column_positions branch December 31, 2024 11:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SlimaneAmar SlimaneAmar SlimaneAmar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@EstherDarkish @SlimaneAmar