Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Making parameter modifications on global Defaults drivers is ignored by the driver client. #1174

Closed
1 task done
vachillo opened this issue Sep 13, 2024 · 1 comment
Closed
1 task done
Labels
type:bug Something isn't working

Comments

@vachillo
Copy link
Member

Describe the bug
Any parameters set after init any drivers that use a client are ignored because the client is initialized during driver initialization

To Reproduce

Defaults.drivers_config = AzureOpenAiDriversConfig(
    azure_ad_token_provider=get_token,
    azure_endpoint=os.environ["AZURE_OPENAI_DEFAULT_ENDPOINT"],
)

Defaults.drivers_config.text_to_speech_driver.azure_endpoint = os.environ[
    "AZURE_OPENAI_OTHER_ENDPOINT"
]

the above fails at runtime because the client used for the AzureOpenAiTextToSpeechDriver does not have the updated endpoint set on the global config.

Expected behavior
The above config should set the correct endpoint for the client on the driver

Screenshots
If applicable, add screenshots to help explain your problem.

Desktop (please complete the following information):

  • OS: [e.g. iOS]
  • Version [e.g. 0.5.1]

Additional context
Add any other context about the problem here.

@vachillo vachillo added the type:bug Something isn't working label Sep 13, 2024
@vachillo vachillo mentioned this issue Sep 13, 2024
1 task
@collindutter
Copy link
Member

@vachillo was this fixed with #1173?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants