-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Drop Python 2.7? #111
Comments
Cross linking: #107 |
I just looked at Grist and their repo is setup with separate requirements.txt files for python 2 and python 3. As long as we don't change the public api, I think we will be fine with removing python 2 support. Since the projects are supposedly tied, the way I suggest we go about it is:
|
Also, new grist installations use python 3.9 by default, so we can also drop 3.5 and 3.6 since they're dead. |
@aqeelat's suggested plan sounds good to me. |
Thank you all, @a-detiste, @alexmojaki, @aqeelat, for the great cleanup! Am I right that the next step is to update README (which currently claims that it works with Python 2) and bump asttokens to version 3? |
That sounds right to me. |
Continuing the discussion in #110 (comment)
I've just noticed that GHA still has PyPy 2.7, which is actually probably enough to say that the library is still being tested on 2.7 and is thus expected to work. Dropping support (i.e. the PyPI classifier) is only valuable if it saves us from doing work to have that confidence.
On the other hand, I don't want people doing (or thinking that they have to do) extra work in the future for the sake of Python 2, e.g. I feel bad about the effort @palfrey went through with mypy and Python 2.
If we do go forward with this, #67 would help.
The text was updated successfully, but these errors were encountered: