Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop Python 2.7? #111

Open
alexmojaki opened this issue Jul 2, 2023 · 4 comments · May be fixed by #117
Open

Drop Python 2.7? #111

alexmojaki opened this issue Jul 2, 2023 · 4 comments · May be fixed by #117

Comments

@alexmojaki
Copy link
Contributor

Continuing the discussion in #110 (comment)

I've just noticed that GHA still has PyPy 2.7, which is actually probably enough to say that the library is still being tested on 2.7 and is thus expected to work. Dropping support (i.e. the PyPI classifier) is only valuable if it saves us from doing work to have that confidence.

On the other hand, I don't want people doing (or thinking that they have to do) extra work in the future for the sake of Python 2, e.g. I feel bad about the effort @palfrey went through with mypy and Python 2.

If we do go forward with this, #67 would help.
@alexmojaki alexmojaki mentioned this issue Jul 2, 2023
Merged
@PeterJCLaw
Copy link
Collaborator

Cross linking: #107

@aqeelat
Copy link

aqeelat commented Jul 6, 2023 •
edited
Loading

@PeterJCLaw @dsagal

I just looked at Grist and their repo is setup with separate requirements.txt files for python 2 and python 3. As long as we don't change the public api, I think we will be fine with removing python 2 support.

Since the projects are supposedly tied, the way I suggest we go about it is:

  1. bump asttokens to version 3 and remove support for python 2
  2. release critical bug fixes to version 2.2.x if needed
  3. update requirements.txt to include asttokens <=2.0.5,<3
  4. update requirements3.txt to include the newer version 3

@aqeelat
Copy link

aqeelat commented Jul 6, 2023 •
edited by dsagal
Loading

Also, new grist installations use python 3.9 by default, so we can also drop 3.5 and 3.6 since they're dead.

@dsagal
Copy link
Member

dsagal commented Aug 29, 2023

@aqeelat's suggested plan sounds good to me.

@aqeelat aqeelat linked a pull request Sep 6, 2023 that will close this issue
Open
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Drop python < 3.8 aqeelat/asttokens
4 participants
@PeterJCLaw @dsagal @alexmojaki @aqeelat