Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Classes for turnouts #6

Open
elperez77 opened this issue Aug 31, 2021 · 8 comments
Open

Classes for turnouts #6

elperez77 opened this issue Aug 31, 2021 · 8 comments
Labels
enhancement testers needed Things that require hardware I don't have

Comments

@elperez77
Copy link

Great job.
is it possible to implement the commands for turnouts?

LAN_X_GET_TURNOUT_INFO
LAN_X_SET_TURNOUT

@grizeldi
Copy link
Owner

grizeldi commented Oct 6, 2021

Back when I last worked on this library, I'm pretty sure those weren't a part of the specification yet. I just checked the spec and it looks like it wouldn't be too hard to implement. However, I don't have my z21 set up at the moment, nor do I have any turnout decoders available, so I couldn't test it.
If you are willing to be a tester I can see what I can do about it.

@grizeldi grizeldi added enhancement testers needed Things that require hardware I don't have labels Mar 22, 2022
@elperez77
Copy link
Author

elperez77 commented Jul 24, 2022

i have implemented this features in my branch

@grizeldi
Copy link
Owner

Can you submit a PR? I don't currently have a z21 set up to test with, but I'd like to at least go through the code.

@elperez77
Copy link
Author

elperez77 commented Jul 27, 2022

what is a PR, i am new on github. sorry

@grizeldi
Copy link
Owner

@elperez77
Copy link
Author

Sorry,
I have already submitted a PR.
do you see the request?

@grizeldi
Copy link
Owner

Huh, my bad for not noticing it. I expected github to send me an email about a new PR, but it just didn't for some reason.
If your last comment on it (that it's not working) is no longer valid, I can take a look.

@elperez77
Copy link
Author

that message is about my first commit ([multiple broadcasts message).
i removed that code in the latest commit.

i implemented turnouts message to z21 and the response message (z21 send broadcast to each client) in order to change the turnouts status in my control panel

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement testers needed Things that require hardware I don't have
Projects
None yet
Development

No branches or pull requests

2 participants