Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No Main within Main #11

Open
taysea opened this issue Aug 4, 2021 · 1 comment
Open

No Main within Main #11

taysea opened this issue Aug 4, 2021 · 1 comment
Labels
enhancement New feature or request

Comments

@taysea
Copy link
Collaborator

taysea commented Aug 4, 2021

Please describe what the rule should do:

A single Main should be used on a page.

What category of rule is this? (place an "X" next to just one item)

[x] Warns about a potential error (problem)
[ ] Suggests an alternate way of doing something (suggestion)
[ ] Other (please specify:)

Provide 2-3 code examples that this rule will warn about:

<Main>
  some stuff
   <Main>
      more stuff
   </Main>
</Main>

Why should this rule be included in eslint-plugin-grommet?

Accessibility best practice

@taysea taysea added the enhancement New feature or request label Aug 4, 2021
@taysea
Copy link
Collaborator Author

taysea commented Dec 27, 2021

This may be difficult to flag for with eslint since components can be abstracted across files / components. However, jest-axe already has a rule that can flag for this in a jest test. Wondering if we could leverage that in a recommended testing setup.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant