Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No direct use of styled-components by callers and no use of the style prop #19

Open
taysea opened this issue Aug 5, 2021 · 0 comments
Labels
enhancement New feature or request

Comments

@taysea
Copy link
Collaborator

taysea commented Aug 5, 2021

Please describe what the rule should do:

Flag if caller has used style on a component or is using styled components directly.

What category of rule is this? (place an "X" next to just one item)

[x] Warns about a potential error (problem)
[ ] Suggests an alternate way of doing something (suggestion)
[ ] Other (please specify:)

Provide 2-3 code examples that this rule will warn about:

<Button label="Label" style={{ border: '1px solid black' }} />

Why should this rule be included in eslint-plugin-grommet?

Grommet best practice -- if something can't be achieve via props or theming then maybe an enhancement is needed.

@taysea taysea added the enhancement New feature or request label Aug 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant