Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Need to discuss what is right level of strictness for formfield rules #48

Open
taysea opened this issue Jul 5, 2023 · 0 comments
Open

Comments

@taysea
Copy link
Collaborator

taysea commented Jul 5, 2023

For the formfield-htmlfor-id and formfield-name rules, we should discuss how to handle the following scenarios. All of these currently don't pass the rules. Should the rule be more flexible? Is it beneficial to force the caller to destructure the props?

  <FormField
    htmlFor={name}
    name={name}
    required={data.required}
    {...rest}
  />
    <FormField
      contentProps={{
        border: formats[kind].border ?? true,
      }}
      label={formats[kind].label || <Text>{label}</Text>}
      name={name}
      htmlFor={name}
      {...formProps}
    >
      <Input {...accessibilityProps} {...inputProps} />
    </FormField>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant