You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Summary:
I would expect an SVG to fill an icon when the "fill" property is applied.
Details:
I'm attempting to use the 'favorite' icon and provide feedback to the user when they have pressed it. The icon, by default shows the outline of a heart symbol. When the css property 'fill' is applied, I would like 'favorite' to fill with the assigned colour.
I'm unsure if this has ever worked but I've tested it in dev tools and it looks like fill is hard coded to 'none' and it seemingly isn't passed the prop...
It would be preferable not to require a separate icon for this. As a side note, if this is intended, perhaps more information could be presented in your documentation? It inherits from SVGAttributes if I've followed the chain correctly, which has made me assume this is a bug
The text was updated successfully, but these errors were encountered:
Labeling this with enhancement/discussion to determine if we would want to support this as a property on an icon or if filled versions should be separate icons themselves.
Summary:
I would expect an SVG to fill an icon when the "fill" property is applied.
Details:
I'm attempting to use the 'favorite' icon and provide feedback to the user when they have pressed it. The icon, by default shows the outline of a heart symbol. When the css property 'fill' is applied, I would like 'favorite' to fill with the assigned colour.
I'm unsure if this has ever worked but I've tested it in dev tools and it looks like fill is hard coded to 'none' and it seemingly isn't passed the prop...
Using:
Simple repro:
It would be preferable not to require a separate icon for this. As a side note, if this is intended, perhaps more information could be presented in your documentation? It inherits from SVGAttributes if I've followed the chain correctly, which has made me assume this is a bug
The text was updated successfully, but these errors were encountered: