Tag - Update Figma component to use "Close" icon.

[ashifalinadaf]

Replacing the close icon for the Tag from 'form icon' to 'core icon'
Related ticket - #3256

Deliverables:

• Create a branch and replace the close icon with 'core icon'.
• Check with other designers and developers.
• Merge with the main branch.
• Create issue for grommet-theme-hpe to implement the Close icon:
  • Allow theme to specify Tag remove icon grommet#6870
  • Update Tag to use Close icon grommet-theme-hpe#363

[ashifalinadaf]

Created a branch and updated all the 'Close Icons' from 'form close icon' to 'core close icon'.

@kenny If you can a look and let me know if there are any issues.

[vavalos5]

@ashifalinadaf I remember taking a look at your branch and seeing that the icons had been replaced. I can take this on and merge it over and create a subsequent ticket for it to be added to grommet.

[ashifalinadaf]

Sure @vavalos5 thank you for reminding this.

[vavalos5]

@KennyAtHPE @taysea Can both of you take a look at the branch and tell me if you notice any of the tags using the incorrect "close icon" please. Thanks!

[taysea]

It looks like the correct icon is being used. Also, if it's a quick fix (<5min) can the page be named "Tag" instead of "Tags"? If not a quick fix, can a ticket be filed to align with the Grommet component name?

[vavalos5]

@taysea Yea, good call out. I'll make those changes today.

[KennyAtHPE]

@vavalos5 can confirm that all the variants are using the correct 'core / close' icon.

[vavalos5]

Icons have been merged to main DS file and published. In addition, the file name was changed from "Tags" to "Tag"