Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Benchmarking command benchmarks all models when max_depth is used #329

Open
danielholanda opened this issue Jun 20, 2023 · 3 comments
Open
Labels
bug Something isn't working p1 mid priority

Comments

@danielholanda
Copy link
Contributor

Issue description

Benchmarking command benchmarks all models when max_depth is used. This happens regardless of the value max_depth as long as max_depth>0.

Reproducing the issue

When running the script below using benchit model.py --analyze-only --max-depth 1 three models are discovered. However, when running benchit model.py --max-depth 1 10+ models are benchmarked.

import torch
import timm
from mlagility.parser import parse

# Creating model and set it to evaluation mode
model = timm.create_model("mobilenetv2_035", pretrained=False)
model.eval()

# Creating inputs
inputs1 = torch.rand((1, 3, 28, 28))

# Calling model
model(inputs1)
@danielholanda danielholanda added bug Something isn't working p1 mid priority labels Jun 20, 2023
@danielholanda
Copy link
Contributor Author

@jeremyfowers
Copy link
Contributor

@danielholanda can you add a bit more detail? Where are the 7 extra models coming from in the benchmarking case?

@danielholanda
Copy link
Contributor Author

@jeremyfowers I didn't spend time analyzing this issue yet. My assumption is that those extra models corresponds to all models that would be identified if --max-depth was set to a 999.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working p1 mid priority
Projects
None yet
Development

No branches or pull requests

2 participants