Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Model size assumes Fp16 data type #330

Open
danielholanda opened this issue Jun 21, 2023 · 1 comment
Open

Model size assumes Fp16 data type #330

danielholanda opened this issue Jun 21, 2023 · 1 comment
Labels
cli Relating to the benchit CLI p2 not a priority

Comments

@danielholanda
Copy link
Contributor

Issue

When analyzing a model MLAgility assumes that the model is using FP16 when printing the model size.

On src/mlagility/analysis/status.py lines +115 to +116:

        # Converting number of parameters to MB assuming 2 bytes per parameter
        model_size = model_info.params * 2 / (1024 * 1024)

Possible solutions

  • Only show the size in MB once the model has been benchmarked (and a data type has been set)
  • Use the datatype of the original model and change the information shown if mlagility modifies the data type (e.g. converts to FP16).
@danielholanda danielholanda added cli Relating to the benchit CLI p2 not a priority labels Jun 21, 2023
@danielholanda
Copy link
Contributor Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cli Relating to the benchit CLI p2 not a priority
Projects
None yet
Development

No branches or pull requests

1 participant