Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add cache and build name to status report #333

Merged
merged 5 commits into from
Jun 23, 2023

Conversation

ramkrishna2910
Copy link
Contributor

@ramkrishna2910 ramkrishna2910 commented Jun 22, 2023

This MR makes the following minor changes for the ONNX Model Zoo work

  • Adds path to cache dir and build name as a part of the status report
  • Adds the ability for the reporting API to fetch multiple columns per model name from the mlagility report

Updated Status:
image

Closes #331

@ramkrishna2910 ramkrishna2910 self-assigned this Jun 22, 2023
@ramkrishna2910 ramkrishna2910 marked this pull request as ready for review June 22, 2023 23:14
Copy link
Contributor

@jeremyfowers jeremyfowers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me but please have @danielholanda review as well. I also left a few topics for discussion in the comments. I am good with committing this change as-is but still want us to be thinking of the future usability.

src/mlagility/analysis/status.py Outdated Show resolved Hide resolved
src/mlagility/analysis/status.py Show resolved Hide resolved
Copy link
Contributor

@danielholanda danielholanda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved, but please address comments before merging

src/mlagility/analysis/status.py Outdated Show resolved Hide resolved
src/mlagility/analysis/status.py Outdated Show resolved Hide resolved
@ramkrishna2910 ramkrishna2910 merged commit 59bcef7 into main Jun 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Show build_name once a workload has been built
3 participants