Allow Jpeg and URLs for image inputs in Motion Detector #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robotrapta
requested changes
Jul 5, 2023
There was a problem hiding this comment.
Why do we want this here? Is it just to make testing easier? Then it should go in the tests. I can imagine scenarios where you'd want a file off local disk, but for real-world usage I can't think of any good reason to want a remote image from http.
Also putting this functionality here messes with encapsulation. This library is chock full of ways to get images into memory from various places. Adding a small sampling of redundant methods in this one place doesn't make a lot of sense to me.
| if filename.startswith("http"): | ||
| image = Image.open(requests.get(filename, stream=True).raw) | ||
| return np.array(image) | ||
| elif filename.endswith("jpeg"): |
There was a problem hiding this comment.
This is quite arbitrary. Not jpg?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.