Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up codebase #34

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

Clean up codebase #34

wants to merge 7 commits into from

Conversation

ErikBoesen
Copy link

I made a few changes to clean up and modernize this repository a bit.

@@ -18,7 +19,7 @@ This project shows the capability of a bot to react to messages sent within a gr

* GroupMe account
* Heroku account
* [Heroku Toolbelt](https://toolbelt.heroku.com/)
* [Heroku CLI](https://devcenter.heroku.com/articles/heroku-cli)
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Heroku Toolbelt is now called Heroku CLI.

@@ -113,37 +114,51 @@ Go to GroupMe and type "/cool guy" in the group where your bot lives to see it i

Within terminal, change directory to the location where you would like the files to live, then run this command:

$ heroku git:clone -a YOUR_APP_NAME_HERE
```sh
heroku git:clone -a YOUR_APP_NAME_HERE
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Syntax highlighting!


## Start the server

To test your bot locally, open terminal and run the following command to start a local server.

$ foreman start
```sh
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Foreman seems nonstandard

@@ -1,7 +1,7 @@
{
"name": "node-js-getting-started",
"name": "bot-tutorial",
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was never changed from wherever it was copied from.

README.md Outdated
@@ -1,8 +1,9 @@
# Sample GroupMe NodeJS Callback Bot
# Sample GroupMe NodeJS Bot
[**Python**](https://github.com/groupme/bot-tutorial-nodejs) | **JavaScript**
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See #33! I have created a Python version of this package which I would love to transfer to the GroupMe GitHub org for public benefit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant