Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make service config more explicit #5758

Open
voidzcy opened this issue May 17, 2019 · 2 comments · May be fixed by #11917
Open

Make service config more explicit #5758

voidzcy opened this issue May 17, 2019 · 2 comments · May be fixed by #11917
Labels
usability
Milestone
Next

Comments

@voidzcy
Copy link
Contributor

voidzcy commented May 17, 2019

Currently when a service config is supplied, we do not know if things are configured correctly as we desired. Service configs are applied silently. This makes it hard to know what goes wrong when using a service config. For example, in #5724, a retry service config is supplied by user but does not correctly applied to the service since the service name in the config was wrong. User sees nothing but retry is not happening. Is it possible to give out some information about what's going on when there is a service config?
@ejona86 ejona86 added this to the Next milestone May 21, 2019
@ejona86 ejona86 assigned ejona86 and dapengzhang0 and unassigned ejona86 May 21, 2019
@eugeniyk
Copy link

@ejona86 do you have any plan to provide object-oriented API for retries? current way in #5724 looks error prone to me - setting up configuration by untyped hashmaps will make compiler silent when API will be changed

@ejona86
Copy link
Member

ejona86 commented Feb 24, 2020

@eugeniyk, there is no plan for a typed API. Service config is designed to be transported via JSON, so the normal case is there is no typed API.

@dapengzhang0 dapengzhang0 assigned ejona86 and unassigned dapengzhang0 Feb 18, 2022
@ejona86 ejona86 removed their assignment Jun 6, 2022
@vinodhabib vinodhabib linked a pull request Feb 21, 2025 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
usability
Projects
None yet
Milestone
Next
4 participants
@voidzcy @ejona86 @eugeniyk @dapengzhang0