Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

udpa to xds proto migration #8631

Closed
YifeiZhuang opened this issue Oct 26, 2021 · 0 comments · Fixed by #8686
Closed

udpa to xds proto migration #8631

YifeiZhuang opened this issue Oct 26, 2021 · 0 comments · Fixed by #8686
Assignees
@YifeiZhuang
Labels
enhancement
Milestone
1.43

Comments

@YifeiZhuang
Copy link
Contributor

Migration plan:
cncf/xds#2 (comment)

PR change: https://github.com/cncf/xds/pull/17/files

  1. We should start using the ORCA protos from the new location.

  2. We should change our code that handles the udpa.type.v1.TypedStruct type URL to also accept xds.type.v3.TypedStruct in the same place.
@YifeiZhuang YifeiZhuang self-assigned this Oct 26, 2021
@ejona86 ejona86 added this to the Next milestone Oct 26, 2021
This was referenced Nov 9, 2021
Closed
Merged
YifeiZhuang added a commit that referenced this issue Nov 11, 2021
@YifeiZhuang
xds: migrate udpa proto to xds directory (#8686)
881747a 
fix #8631:
1. import udpa protos form new git repo `https://github.com/cncf/xds.git` instead of  `https://github.com/cncf/udpa.git`
2. use proto from xds directory not udpa directory in `https://github.com/cncf/xds.git`, details was here cncf/xds#2 (comment)
3. support both versions of TypeStruct
4. remove v1 orca service in old directory and use the new one v3, and refer to v3 in ORCA related area
@dapengzhang0 dapengzhang0 modified the milestones: Next, 1.43 Nov 30, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 1, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@YifeiZhuang YifeiZhuang

Labels
enhancement
Projects
None yet
Milestone
1.43
Development

Successfully merging a pull request may close this issue.

xds: migrate udpa proto to xds directory YifeiZhuang/grpc-java
3 participants
@ejona86 @YifeiZhuang @dapengzhang0