Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document the Client/ServerInterceptor requirements #1620

Open
weissi opened this issue Jun 22, 2023 · 0 comments
Open

Document the Client/ServerInterceptor requirements #1620

weissi opened this issue Jun 22, 2023 · 0 comments
Labels
kind/bug Feature doesn't work as expected.

Comments

@weissi
Copy link
Contributor

weissi commented Jun 22, 2023 •
edited
Loading

Neither the doc comments ClientInterceptor docs nor the Interceptors Tutorial actually mention that you must forward the parts in exactly the same order as you received them which makes async interception hard.

See also #1618 / #1619 / #1181 and https://stackoverflow.com/questions/76534719/eventloopfuture-causing-invalid-state-unable-to-write-message/76535053#76535053 where this went wrong
@weissi weissi added the kind/bug Feature doesn't work as expected. label Jun 22, 2023
This was referenced Jun 22, 2023
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/bug Feature doesn't work as expected.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@weissi