Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

While showing a PDF or other binary, also show the converted file. #14

Open
janmichaelyu opened this issue May 24, 2017 · 5 comments
Open

Comments

@janmichaelyu
Copy link

Maybe take a convertedUri parameter and show that document when clicking a button.

@grtjn
Copy link
Owner

grtjn commented May 26, 2017

What would be the benefit over using multiple view-file directives with different params? It could be interesting, just looking for good arguments..

You could also suppress the toolbar from view-file, and put some toolbar next to view-file directives yourself.

@janmichaelyu
Copy link
Author

Something like:

As a user I would like to search for PDFs using a term and clicking on the results (converted documents) would also show the original PDF.

@grtjn
Copy link
Owner

grtjn commented May 27, 2017

Like said before, I think you could do this relatively easily with multiple view-file directives on one page..

@janmichaelyu
Copy link
Author

Ok. Will experiment. I used uib-tabs to show both the pdf and the converted xml but didn't like how it looked.

@grtjn
Copy link
Owner

grtjn commented May 27, 2017

Let us chat offline next week. I'm still interested in allowing extra stuff to be shown, but need to think how to make it work generically..

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants