Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider removing word-break css #17

Open
patrickmcelwee opened this issue Jul 3, 2017 · 3 comments
Open

Consider removing word-break css #17

patrickmcelwee opened this issue Jul 3, 2017 · 3 comments
Labels

Comments

@patrickmcelwee
Copy link

This line caused our html preview to consistently line break randomly in the middle of words, a fact pointed out by the customer: https://github.com/grtjn/view-file-ng/blob/master/less/view-file-ng.less#L41

I would recommend taking out that line. The word-wrap option will still allow long words to break, I believe.

Otherwise, works great!

@grtjn
Copy link
Owner

grtjn commented Jul 3, 2017

Yeah, probably a better default, thanks.

Long words, or long values are not broken automatically though, only if they contain spaces or hyphens if I recall correctly. Then again, the word-break all can be applied easily afterwards, if people have need for it..

I'll look into it..

@grtjn grtjn added the bug label Jul 3, 2017
@patrickmcelwee
Copy link
Author

patrickmcelwee commented Jul 11, 2017

Since this ticket is about css, thought I'd mention that I needed to remove this {overflow: scroll}: https://github.com/grtjn/view-file-ng/blob/master/less/view-file-ng.less#L47

For HTML that was not long, it created unsightly blank scroll bars on bottom and right.
screen shot 2017-07-11 at 10 48 03 am

But when I set it back to {overflow: auto}, it still gives scroll bars for long content, but hides them when the content is small.

@grtjn
Copy link
Owner

grtjn commented Jul 13, 2017

There was a reason why I had it like that, but forgot to write down what it was. Thanks for reporting this..

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants