Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarity around zlib usage #44

Open
grunt-lucas opened this issue Apr 13, 2024 · 0 comments
Open

Clarity around zlib usage #44

grunt-lucas opened this issue Apr 13, 2024 · 0 comments
Assignees
Labels
meta Repository housekeeping

Comments

@grunt-lucas
Copy link
Owner

grunt-lucas commented Apr 13, 2024

It seems that libpng is dependent on zlib. MacOS ships with a default zlib, but Porytiles uses the latest via homebrew. This should be made clear in the install instructions, or I should change MacOS Porytiles to use the default zlib. Note that homebrew libpng declares its zlib dependency to be the MacOS shipped zlib: https://github.com/Homebrew/homebrew-core/blob/master/Formula/lib/libpng.rb

I think I added it explicitly because for linux builds, I link statically. And hence libpng needs zlib installed to link properly. However, for the dynamically linked MacOS builds, I don't actually need to specify zlib specifically, since it is specified as a private requirement in libpng. I should clean up the makefile and build scripts accordingly so it's not so confusing.

@grunt-lucas grunt-lucas added the meta Repository housekeeping label Apr 13, 2024
@grunt-lucas grunt-lucas self-assigned this Apr 13, 2024
@grunt-lucas grunt-lucas changed the title Is zlib necessary for building? Clarity around zlib usage Apr 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
meta Repository housekeeping
Projects
None yet
Development

No branches or pull requests

1 participant