Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rarefaction in private_alleles function #195

Open
3 of 5 tasks
afontcub opened this issue Jan 16, 2019 · 2 comments
Open
3 of 5 tasks

rarefaction in private_alleles function #195

afontcub opened this issue Jan 16, 2019 · 2 comments

Comments

@afontcub
Copy link

afontcub commented Jan 16, 2019

  • I have the most recent version of poppr and R
  • I have found a bug
  • I want to request a new feature

Hi! I am calculating the number of private alleles with rarefaction, using a loop to resample my populations to a standard sample size and then apply the private_alleles function.
But, it would be amazing if you could implement a rarefaction correction inside the private_alleles function! For example, with the unbiased estimator proposed by Kalinowski (Kalinowski, 2004. Conservation Genetics.)

Thank you very much in advance!

Amaranta.

@zkamvar
Copy link
Member

zkamvar commented Jan 17, 2019

Thanks for the suggestion. I also think this would be a good thing to implement, however, my capacity for adding new functionality to poppr is a bit limited at the time. I may have some time to take a look at this in February or March. I'm assuming that the paper you are referring to is: http://www.montana.edu/kalinowski/documents/2004_Rarefaction_ConservationGenetics.pdf

In the meantime, one thing that would help with this would be a small test data set that would produce a known value with this method. Also, if you are comfortable using git and github, and have this solution already coded using poppr, feel free to create a pull request and I'll review it :)

Feel free to ping me again if there's no activity for a while.

@zoemeziere
Copy link

Hi! I am also using the private_alleles function and find large discrepancies between populations due to sample sizes differences. Do you have any hint on how to implement rarefaction to the function to account for that? Cheers!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants