Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GRAI regex wrong #4

Open
JohannesFluegel opened this issue Mar 22, 2022 · 2 comments
Open

GRAI regex wrong #4

JohannesFluegel opened this issue Mar 22, 2022 · 2 comments

Comments

@JohannesFluegel
Copy link

I don't know if your GRAI regex (\d{14})([\x21-\x22\x25-\x2F\x30-\x39\x41-\x5A\x5F\x61-\x7A]{0,16}) might be wrong. It means 14 digits then 0 to 16 special chars. But in https://www.gs1.org/docs/Digital-Link/GS1_Digital_link_Standard_i1.1.pdf, page 21 we read

grai-value = 14DIGIT 1*16XCHAR
; 14 digits then 1-16 characters
; from the 82-character subset of ISO/IEC 646

@mgh128
Copy link
Contributor

mgh128 commented Mar 22, 2022

Hi @JohannesFluegel
Thanks for the feedback. This was one of the things recently fixed in an errata fix to the published GS1 Digital Link v1.2 URI Syntax https://www.gs1.org/docs/Digital-Link/GS1_Digital_Link_Standard_URI_Syntax_r_i1-2-1_2022-02-08.pdf where on page 19 you'll now see

grai-value = 14DIGIT [1*16XCHAR]
; 14 digits then optional 1-16 characters
; from the 82-character subset of ISO/IEC 646

towards the end of section 4.5.

Please refer to GS1 Digital Link v1.2 URI Syntax for all current ABNF grammar.

Tagging @philarcher - should the recent errata fixes from 2022 also be applied to the GS1 Digital Link v1.1 standard in case anyone is still referring to it?

@philarcher
Copy link
Member

Thanks @JohannesFluegel for raising this and @mgh128 for answering so promptly.

I don't think DL version 1.1 needs updating as such. The currently published URI Syntax version 1.2.1 supersedes the equivalent sections in 1.1, which is where these errata have been corrected. Sure, we do want to update the remainder of 1.1 but, in terms of published normative statements, the primacy of URI Syntax version 1.2.1 is, I hope, clear.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants