Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 On certain mobile devices Overlay animation is not smooth #931

Open
fraincs opened this issue Mar 30, 2022 · 3 comments
Open

🐛 On certain mobile devices Overlay animation is not smooth #931

fraincs opened this issue Mar 30, 2022 · 3 comments
Assignees

Comments

@fraincs
Copy link
Contributor

fraincs commented Mar 30, 2022

Describe the bug

On certain devices (iPhone SE 2022), the modal animation is choppy.

Steps to reproduce

Using an iPhone SE open a Modal.

Expected results

The animation is smooth, like on other devices.

Reproducible demo

Image.from.iOS.MP4
@fraincs fraincs added the bug label Mar 30, 2022
@fraincs fraincs self-assigned this Mar 30, 2022
@fraincs
Copy link
Contributor Author

fraincs commented Oct 17, 2022

Is that on Safari or Chrome?

@fraincs
Copy link
Contributor Author

fraincs commented Oct 17, 2022

@patricklafrance when you have the chance can you test this?

<ModalTrigger>
    <Button variant="secondary">Open</Button>
    <Modal>
        <Heading>Cloud City</Heading>
        <Content>
            <Paragraph>
                Cloud City was a completely man-made tibanna gas mining colony staff hovering over
                the gas giant Bespin, occupied by millions of workers, tourists and support staff.
                Located in Bespin's Life Zone, the station had no need for airlocks or life support
                systems, with the atmosphere comprised mostly of oxygen and acceptable levels of
                gravity and temperature.
            </Paragraph>
            <Paragraph>
                The station was situated 59,000 kilometers above Bespin's core, while its disk was
                approximately 16.2 kilometers in diameter. 36,000 repulsorlift engines and tractor
                beam generators kept the giant city floating above the planet. It contained 392
                levels, along with platforms and rooms for residents and visitors.
            </Paragraph>
        </Content>
    </Modal>
</ModalTrigger>

I'm starting to think the issue if more linked to the fact that the height of the SE viewport is not very high and an overflowing modal is causing issue. Testing with Browserstack the animation seems fluid with a small Modal, still hard to tell on a video stream of a real device.

@patricklafrance
Copy link
Member

Have you find out the issue @fraincs ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants