Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support forever scope #1372

Open
bilelmoussaoui opened this issue Jul 20, 2022 · 4 comments
Open

Support forever scope #1372

bilelmoussaoui opened this issue Jul 20, 2022 · 4 comments

Comments

@bilelmoussaoui
Copy link
Member

Currently gir fails with when trying to generate Pango2 (1.90 currently) bindings

Error: Error: "GirXml: pango2/sys/../../Pango2-1.0.gir at line 1775:11: Attribute `scope` on element <parameter> has invalid value: Unknown parameter scope type: forever"
@sdroege
Copy link
Member

sdroege commented Jul 20, 2022

Yeah that's an easy one. GStreamer also has a couple of those but not annotated accordingly and manually bound.

@bilelmoussaoui
Copy link
Member Author

Do you remember which ones that needs to be fixed so I can try my changes?

@sdroege
Copy link
Member

sdroege commented Jul 20, 2022

They will continue to stay manual because of other issues. gst_tag_register() for example.

@Vanadiae
Copy link

I also tried generating pango2 bindings and encountered the same issue. After some grepping and code reading it looks like the code that need to be changed live in library.rs and analysis/rust_type.rs, but apart from that I've no knowledge about how gir works. For now I've replaced the "forever" scopes with "call" even if that's wrong, but I won't use pango2_attr_type_register() for now so that's not so much of an issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants