Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Package dropdowns break with empty namespace #85

Open
mcombuechen opened this issue May 30, 2024 · 2 comments · May be fixed by #86
Open

Package dropdowns break with empty namespace #85

mcombuechen opened this issue May 30, 2024 · 2 comments · May be fixed by #86
Labels
bug Something isn't working

Comments

@mcombuechen
Copy link

When dealing with packages without a namespace, the package selector dropdowns don't play nicely. For example, when dealing with package pkg:npm/[email protected], it is impossible to ever get to the selection of the package and version since the empty namespace will keep the package name selector disabled.

Furthermore, the empty namespace will show up as a slightly smaller option due to the label being an empty string.
mcombuechen added a commit to mcombuechen/guac-visualizer that referenced this issue May 30, 2024
@mcombuechen
fix: default to non-breaking space in namespace option labels
33fa747 
Closes guacsec#85.

Signed-off-by: Maximilian Combüchen <[email protected]>
mcombuechen added a commit to mcombuechen/guac-visualizer that referenced this issue May 30, 2024
@mcombuechen
fix: handle empty string values in package selectors
854b56f 
Closes guacsec#85.

Signed-off-by: Maximilian Combüchen <[email protected]>
@mcombuechen
Copy link
Author

The empty namespace renders as a UI bug in react-select:

Screenshot 2024-05-30 at 09 23 44

@mcombuechen
Copy link
Author

The package name selector remains disabled when the empty namespace was selected:

Screenshot 2024-05-30 at 09 24 02

@mcombuechen mcombuechen linked a pull request May 30, 2024 that will close this issue
Open
@funnelfiasco funnelfiasco added the bug Something isn't working label Sep 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Handle empty package namespace in package selectors mcombuechen/guac-visualizer
2 participants
@funnelfiasco @mcombuechen