Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: updates go.mod to use the new uri for nhooyr.io/websocket #2329

Closed
wants to merge 1 commit into from
Closed

fix: updates go.mod to use the new uri for nhooyr.io/websocket #2329

wants to merge 1 commit into from

Conversation

semmet95
Copy link
Contributor

Description of the PR

Fixes #2328

Fix source: grafana/grafana#92739 (comment)

PR Checklist

  • All commits have a Developer Certificate of Origin (DCO) -- they are generated using -s flag to git commit.
  • All new changes are covered by tests
  • If GraphQL schema is changed, make generate has been run
  • If GraphQL schema is changed, GraphQL client updates/additions have been made
  • If OpenAPI spec is changed, make generate has been run
  • If ent schema is changed, make generate has been run
  • If collectsub protobuf has been changed, make proto has been run
  • All CI checks are passing (tests and formatting)
  • All dependent PRs have already been merged

@semmet95 semmet95 force-pushed the fix/nhooyr-dependency-path-update branch 2 times, most recently from 25a2637 to b214769 Compare December 3, 2024 00:51
@semmet95 semmet95 force-pushed the fix/nhooyr-dependency-path-update branch from b214769 to c916bcd Compare December 3, 2024 11:34
pxp928
pxp928 reviewed Dec 3, 2024
View reviewed changes
go.mod
@@ -356,3 +356,5 @@ require (
golang.org/x/time v0.8.0
gopkg.in/yaml.v3 v3.0.1
)

replace nhooyr.io/websocket => github.com/coder/websocket v1.8.7
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hmm, I am not getting any error related to this when I run go mod tidy?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am on latest main and everything seems fine.

Copy link
Contributor Author

@semmet95 semmet95 Dec 4, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pxp928
Strangely, I'm still getting this error in my linux machine even though it works fine on mac.
I'll close this PR as draft for now.

@semmet95 semmet95 closed this Dec 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pxp928 pxp928 pxp928 left review comments

Assignees
No one assigned
Labels
size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[bug] go mod tidy command failing because of nhooyr.io/websocket dependency
2 participants
@semmet95 @pxp928