Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature] Add EOL to e2e test #2395

Open
robert-cronin opened this issue Dec 20, 2024 · 0 comments · May be fixed by #2396
Open

[feature] Add EOL to e2e test #2395

robert-cronin opened this issue Dec 20, 2024 · 0 comments · May be fixed by #2396
Labels
enhancement New feature or request

Comments

@robert-cronin
Copy link
Contributor

Is your feature request related to a problem? Please describe.
Some recent issues have emerged with the EOL certifier introduced in #2215, specifically its failure to produce EOL-related HasMetadata nodes and some CLI issues. Currently, the EOL-on-ingest functionality isn’t validated in our end-to-end tests, making it difficult to prevent regressions or confirm fixes.

Describe the solution you’d like
Following the pattern from #2142, we can enhance the e2e test suite by adding the --add-eol-on-ingest flag. We’d then target a package known to have passed its EOL according to endoflife.date data, ensuring the certifier works as intended in a full integration scenario.

Describe alternatives you’ve considered
N/A

Additional context
Before implementing this, let’s allow recent corrective PRs (#2394 and #2391) to be merged. Once these changes are in, I’ll open a PR to add the e2e coverage and address any lingering issues.

@robert-cronin robert-cronin added the enhancement New feature or request label Dec 20, 2024
@robert-cronin robert-cronin linked a pull request Dec 20, 2024 that will close this issue
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant