Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clarify what this repo is for #8

Open
aspiers opened this issue Dec 28, 2017 · 0 comments
Open

clarify what this repo is for #8

aspiers opened this issue Dec 28, 2017 · 0 comments

Comments

@aspiers
Copy link

aspiers commented Dec 28, 2017

The title at https://github.com/guard/guard-compat/ is "Test helper for testing Guard plugins", and the first line of the README.md is:

Currently, provides only a test helper for testing custom Guard plugins.

... but then it goes on to include sections such as "Migrating your API calls", which are apparently not specific to testing guard plugins. And there is no explanation why any plugin author would want or need to migrate API calls. Maybe I'm being stupid, but I have been hacking on several Guard plugins sporadically for several years, and despite being fairly far from a Guard newbie I'm a bit confused by this.

I would normally assume that any module/gem/plugin with compat in the name would exist solely to provide a compatibility layer, so that consumers of older APIs would still work. This is a standard development pattern, which has the goal of eventually dropping the deprecated APIs, and the corresponding compatibility layer. But the => arrows in this section seem to suggest the opposite, i.e. that Guard::Compat::* are the recommended APIs, and https://github.com/guard/guard-compat/blob/master/lib/guard/compat/example.rb seems to corroborate this.

So please can we clarify which are the new APIs and which are the old APIs, and when/why guard-compat should be used? For example it seems strange for what is apparently a canonical example of a guard plugin implementation (also corroborated by Create a guard) to live in a compat repository rather than the main repository.

Thanks a lot!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant