Validate setter profile URL

guardian · Jan 30, 2025 · acb38d0 · acb38d0
1 parent b9beaf9
commit acb38d0
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 4 deletions.
diff --git a/dotcom-rendering/src/components/ArticleMeta.web.tsx b/dotcom-rendering/src/components/ArticleMeta.web.tsx
@@ -401,7 +401,7 @@ export const ArticleMeta = ({
 							{crossword?.creator && (
 								<CrosswordSetter
 									setter={crossword.creator.name}
-									profile={crossword.creator.webUrl}
+									profileUrl={crossword.creator.webUrl}
 								/>
 							)}
 

diff --git a/dotcom-rendering/src/components/CrosswordSetter.tsx b/dotcom-rendering/src/components/CrosswordSetter.tsx
@@ -17,17 +17,22 @@ const setterStyles = css`
 	}
 `;
 
+const isValidProfileUrl = (url: string): boolean => {
+	return url.startsWith('https://www.theguardian.com/profile/');
+};
+
 type Props = {
 	setter: string;
-	profile: string;
+	profileUrl: string;
 };
 
-export const CrosswordSetter = ({ setter, profile }: Props) => (
+export const CrosswordSetter = ({ setter, profileUrl: profile }: Props) => (
 	<address
 		css={setterStyles}
 		data-component="meta-byline"
 		data-link-name="byline"
 	>
-		Set by: <a href={profile}>{setter}</a>
+		Set by:{' '}
+		{isValidProfileUrl(profile) ? <a href={profile}>{setter}</a> : setter}
 	</address>
 );