-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handle crossword articles #12925
Open
sndrs
wants to merge
12
commits into
main
Choose a base branch
from
e2e/add-react-crossword
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Handle crossword articles #12925
+755
−27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Size Change: +11.6 kB (+1.24%) Total Size: 953 kB
ℹ️ View Unchanged
|
sndrs
force-pushed
the
e2e/add-react-crossword
branch
from
November 28, 2024 17:52
0789e74
to
8a244f7
Compare
sndrs
force-pushed
the
e2e/add-react-crossword
branch
from
December 9, 2024 16:50
2e7e45f
to
3fe07f7
Compare
sndrs
requested review from
oliverabrahams and
JamieB-gu
and removed request for
a team
December 9, 2024 16:51
JamieB-gu
reviewed
Dec 11, 2024
sndrs
commented
Dec 11, 2024
sndrs
commented
Dec 11, 2024
sndrs
commented
Dec 11, 2024
sndrs
commented
Dec 11, 2024
sndrs
commented
Dec 11, 2024
sndrs
commented
Dec 11, 2024
sndrs
commented
Dec 11, 2024
github-actions
bot
added
apps-rendering
and removed
run_chromatic
Runs chromatic when label is applied
labels
Dec 12, 2024
this is a first pass, it needs work
and use JSdoc for editor assistance
sndrs
force-pushed
the
e2e/add-react-crossword
branch
from
December 12, 2024 13:35
bf139e7
to
8c33976
Compare
github-actions
bot
removed
the
run_chromatic
Runs chromatic when label is applied
label
Dec 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
based heavily on the work done by @andrew-nowak in #12511, this is first pass of getting crosswords working in DCR.
it does not include layout changes, because there's work to be done in CAPI client and frontend to support that.
those will come in #13001.