Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong campaign name mapping for failed paper (Home Delivery) checkouts #5296

Open
graham228221 opened this issue Sep 27, 2023 · 2 comments
Open

Comments

@graham228221
Copy link
Contributor

This should actually be print-failed, not paper-failed:

The name (DataExtensionName) must match the mapping in membership-workflow here: https://github.com/guardian/membership-workflow/blob/main/conf/PROD.public.conf#L49C10-L49C10

@andrewHEguardian
Copy link
Contributor

@graham228221 is this still an issue?

@graham228221
Copy link
Contributor Author

@graham228221 is this still an issue?

I think so, it should be print-failed to match membership-workflow here: https://github.com/guardian/membership-workflow/blob/930f01291dacff565e32661d794a8abacf8ce7da/conf/PROD.public.conf#L50C5-L50C17 - this would cause an error in the membership-workflow queue, meaning no email would be sent.

But actually, the campaign that print-failed corresponds to if switched off in Braze: https://dashboard-01.braze.eu/engagement/campaigns/5da4706298cf4b552292cd31/5b75933b36dc781650d85641?locale=en&page=-2 and I just noticed that it shares the same campaign id as digipack-failed. So there's a few problems here, but yes I think this should be updated in support-frontend so that there is at least a corresponding mapping in membership-workflow.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants