Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some more prep for revamped sourcegens and CI #3572

Closed
1 of 5 tasks
dodexahedron opened this issue Jun 26, 2024 · 2 comments
Closed
1 of 5 tasks

Some more prep for revamped sourcegens and CI #3572

dodexahedron opened this issue Jun 26, 2024 · 2 comments
Assignees
Labels
breaking-change For PRs that introduces a breaking change (behavior or API) build-and-deploy Issues regarding to building and deploying Terminal.Gui dependencies Pull requests that update a dependency file design Issues regarding Terminal.Gui design (bugs, guidelines, debates, etc...) enhancement v2 For discussions, issues, etc... relavant for v2 work-in-progress
Milestone

Comments

@dodexahedron
Copy link
Collaborator

dodexahedron commented Jun 26, 2024

This issue is primarily for the next piece of preparation for a couple of other issues, such as splitting off the enum generators and enhancements to the CI pipeline that kinda come along for free with that.

But it's also a good spot to bring in a couple other related but small pieces of work which also share the goal of simplification of the build and also the consumer's experience with the packaged library.

At a high level, this one will come with at least:

  • Additional configurations added to the solution and projects for which they are relevant.
    • At minimum, some specifically meant for builds/tests/deployments in CI, which also aim to improve the design-time experience by making that stuff not part of local builds unless you want it to be, by choosing the CI configurations.
  • Take a pass over dependencies and reduce where feasible.
  • Include a pre-packaged form of the enum generators and remove the projects from the solution.
    • Also going to drop a README.md in the Analyzers and project directories under Analyzers with a note that they're deprecated and slated for replacement soon, just in case someone comes along and wants to add onto them or something. 🤷‍♂️
  • Declare existing classes in the Roslyn projects as partial and add a conditionally-compiled file that adds [Obsolete] to all of them, with the condition not being true by default until later, by flipping a switch, when the change to using the external package is almost ready to go.
    • I'll make a PR for that switch flip when it's time.
    • This is really just an insurance policy, but it's almost 0-effort, so might as well go for it.
  • Probably other minor stuff I'll mention if/when they come up.
@dodexahedron dodexahedron self-assigned this Jun 26, 2024
@dodexahedron dodexahedron added enhancement work-in-progress design Issues regarding Terminal.Gui design (bugs, guidelines, debates, etc...) build-and-deploy Issues regarding to building and deploying Terminal.Gui breaking-change For PRs that introduces a breaking change (behavior or API) dependencies Pull requests that update a dependency file v2 For discussions, issues, etc... relavant for v2 labels Jun 26, 2024
@dodexahedron dodexahedron added this to the V2 Alpha milestone Jun 26, 2024
@dodexahedron
Copy link
Collaborator Author

A few of the mentioned items are already done in my working tree, but I've got plenty more to do for that task list above.

@dodexahedron
Copy link
Collaborator Author

Oh hey.

Sorry I was busy and then out of town and then busy again.

But update here.

For sake of simplicity I figured I'd just remove them altogether for now and they can be referenced again closer to release or even in a point release, since it's purely optimization anyway. Yes, sometimes significant, but still not a huge deal. 🤷‍♂️

Any objections?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking-change For PRs that introduces a breaking change (behavior or API) build-and-deploy Issues regarding to building and deploying Terminal.Gui dependencies Pull requests that update a dependency file design Issues regarding Terminal.Gui design (bugs, guidelines, debates, etc...) enhancement v2 For discussions, issues, etc... relavant for v2 work-in-progress
Projects
Status: ✅ Done
Development

No branches or pull requests

2 participants