v2: Keyboard navigation on MessageBox no longer working

[fergusonr]

2.0.0-v2-develop.2164
Keyboard navigation of messageBox buttons no longer works. Left/right arrows do not navigate buttons

Reproduce

MessageBox.Query(50, 7, "Quit?", "Are you sure you want to quit?", 0, "Yes", "No");

Expected behavior

[tig]

On it. Thanks!

[tig]

Actually, the problem is not navigation, but drawing.

I changed how MessageBox worked. Previously the text was rendered by a subview. This was a legacy from early v1 where View.Text didn't exist. I removed this subview and made it so the MessageBox text was just Dialog.Text. However, because the "Dialog" ColorScheme inverts Normal/Focus, this caused the Text to be drawn inverted from what you'd expect.

To fix THIS, I mistakenly was setting Dialog.ColorScheme in MessageBox.cs.

The fix (temporary) is to override GetNormalColor/GetFocusColor in Dialog to always return Normal. PR incomming.

Long term, the fix needs to be in #2381

[fergusonr]

All good now. thankyou!