Fixes #3875. Add left and right tab sides with alignments to the TabView. #3876
Conversation
…rks on alignments.
…iew-left-right-feature
|
@tig there are 4 unit tests failing because the Add_Three_TabsSide_Left_ShowInitialLine_False_ChangesTab_Height5
Expected:
───────────────────┐
Tab1 hi │
────╮ │
Tab2│ │
────▼──────────────┘
But Was:
───────────────────┐
Tab1 hi │
────╮ │
Tab2│ │
────╯──────────────┘
Add_Three_TabsSide_Left_ShowInitialLine_True_ChangesTab_Height5
Expected:
╭──────────────────┐
│Tab1 hi │
├────╮ │
│Tab2│ │
╰────▼─────────────┘
But Was:
╭──────────────────┐
│Tab1 hi │
├────╮ │
│Tab2│ │
╰────╯─────────────┘
Add_Three_TabsSide_Right_ShowInitialLine_False_ChangesTab_Height5
Expected:
┌───────────────────
│hi Tab1
│ ╭────
│ │Tab2
└──────────────▼────
But Was:
┌───────────────────
│hi Tab1
│ ╭────
│ │Tab2
└──────────────╰────
Add_Three_TabsSide_Right_ShowInitialLine_True_ChangesTab_Height5
Expected:
┌──────────────────╮
│hi Tab1│
│ ╭────┤
│ │Tab2│
└─────────────▼────╯
But Was:
┌──────────────────╮
│hi Tab1│
│ ╭────┤
│ │Tab2│
└─────────────╰────╯The strange is if there isn't enough space to add another tab an vertical line is added and the down arrow is draw. This issue only happens if the height fit exactly the tabs than can be currently visible. |
|
It was a bug with the |
| private void Tab_DisplayTextChanged (object? sender, EventArgs e) { _tabLocations = CalculateViewport (Viewport); } | ||
|
|
||
| /// <summary>Renders the line with the tab names in it.</summary> | ||
| private void RenderTabLine (Tab []? tabLocations) |
There was a problem hiding this comment.
Actually, this method is just mis-named causing me to think you were doing drawing w/in Layout.
| } | ||
|
|
||
| LineCanvas.Merge (lc); | ||
| } | ||
|
|
||
| /// <summary>Renders the line of the tab that adjoins the content of the tab.</summary> | ||
| private void RenderUnderline () |
There was a problem hiding this comment.
Please rename this method to something that actually describes what it does.
| } | ||
|
|
||
| LineCanvas.Merge (lc); |
There was a problem hiding this comment.
The above code is insane.
1000 lines of highly repetitive logic that could be replaced with just a few lines if this were completed:
I get annoyed that you continue to expand on this vs. helping me think through how to make #3407 really work well.
Fixes
Proposed Changes/Todos
Pull Request checklist:
CTRL-K-Dto automatically reformat your files before committing.dotnet testbefore commit///style comments)