Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Unintended] feature: bamstats fails if the number of BAM references exceeds ulimit -n #32

Open
markb729 opened this issue Dec 24, 2020 · 0 comments

Comments

@markb729
Copy link

Using the packaged bamstats-v0.3.5-linux-x86_64 or a locally compiled (go1.15.6 linux/amd64) dev version on CentOS 7, bamstats will crash with "panic: <fileID.bam> too many open files" if the number of BAM references contained therein exceeds the system file open limit, given by ulimit -n (often 1024 but can vary considerably among machines).

For many high-quality genomes, the number of chromosomes, scaffolds and contigs is generally much less than 1024 - no problem for bamstats. However, in many draft genomes, this is no longer true thus limiting the applicability of bamstats to a broader audience, at least those who work in draft genome assemblies.

I have never worked in go but I suspect that this feature may result from not closing streams that were opened implicitly. In any case, I hope you can address this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant