Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Downloads should be properly checked before ShellExecute() them #45

Open
Jens-G opened this issue May 24, 2023 · 0 comments
Open

Downloads should be properly checked before ShellExecute() them #45

Jens-G opened this issue May 24, 2023 · 0 comments

Comments

@Jens-G
Copy link

Jens-G commented May 24, 2023

Besides the question why curl is called with CURLSSLOPT_NO_REVOKE there is no validation whatsoever on the downloads. The update file is just downloaded and feed into ShellExecute().

In contrast, when I download the update manually there are plenty of signature files to check against. It is somewhat unexpected to find that an automated tool like WinGUp seems to be totally free of that burden and just skips that part.
chcg pushed a commit to chcg/wingup that referenced this issue Aug 12, 2023
@Regnander @donho
Update swedish.xml
ccd0dee 
Adjusted white-spaces

Close gup4win#45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Jens-G