Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Encoding Issue: unsupported type structpb.isValue_Kind #229

Open
pquerna opened this issue Feb 21, 2024 · 2 comments
Open

Encoding Issue: unsupported type structpb.isValue_Kind #229

pquerna opened this issue Feb 21, 2024 · 2 comments

Comments

@pquerna
Copy link
Contributor

pquerna commented Feb 21, 2024

Hello!

We have a bunch of Protobuf-based objects, which we use code generation to generate the ItemMarshaler and ItemUnmarshaler functions.

Since the new encoder went in #224 -- it looks like all struct fields are recursively scanned for support, even if the top level struct implements the Marshaler and Unmarshaler functions.

This leads to an error like this when we try to use dynamo:

dynamo marshal: unsupported type structpb.isValue_Kind

This is a nested field under one of our objects [our object as a Field of -> struct.Struct -> struct.Value]
https://pkg.go.dev/google.golang.org/protobuf/types/known/structpb#Value

Is it possible, if the top level object passed in implements the Marhsler interface, to not recursively scan the type?

@guregu
Copy link
Owner

guregu commented May 4, 2024

Sorry about that. I'll try and get a fix out this weekend.

@guregu
Copy link
Owner

guregu commented May 4, 2024

Just released v1.22.2 which should fix this. Please try it out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants