Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade the icon #16

Open
sylveon opened this issue Oct 1, 2016 · 4 comments
Open

Upgrade the icon #16

sylveon opened this issue Oct 1, 2016 · 4 comments

Comments

@sylveon
Copy link

sylveon commented Oct 1, 2016

The current dates from Windows XP

There's a really good candidate from imageres.dll
capture

@gurnec
Copy link
Owner

gurnec commented Oct 1, 2016

Unfortunately, I can't just rip Microsoft's copyrighted icons out of Windows and redistribute them, and I'd rather not rewrite HashCheck to directly load the icons from imageres.dll at runtime (I assume it'd be possible?) if I can avoid it--it's a lot of work for not much benefit.

However, Microsoft does offer a Visual Studio image pack with far more permissive redistribution rights. I'll take a look in there to see if this icon (or something similar) is available.

In any case, thanks for the idea!

@sylveon
Copy link
Author

sylveon commented Oct 1, 2016

The file type icon's path is stored in HKEY_LOCAL_MACHINE\SOFTWARE\Classes\HashCheck\DefaultIcon. You can make it point to the imageres.dll's icon instead of the built-in icon.

You can change the key with the installer after the DLL is registered or change the following code so that it directly points the imageres.dll icon instead of the built-in when the DLL registers.

Please note that the icon is only available starting from Windows 8, so the DLL/installer should fallback on the built-in when the OS is older.

@gurnec
Copy link
Owner

gurnec commented Oct 1, 2016

Thanks for the additional info.

There's also the icon that's displayed in the upper left of any HashCheck window that's running and on the task bar (search for IDI_FILETYPE in the code, it wouldn't be too hard to change, but is it worth it?), and even worse there's the one (two and counting if you consider this branch) in the context menu handler which needs to be in BMP format, not ICO format....

@sylveon
Copy link
Author

sylveon commented Oct 1, 2016

I personnaly prefer to have an empty context menu icon because currently it's the only one having an icon and stands a bit too much:
2016-10-01 1

But if you want to still show an icon in the context menu, it's not hard to do (Maybe consider an toggle to hide the icon in the settings also)

I'm not sure if the window icon is worth the trouble, I only use the properties panel. Depends if it's used a lot.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants