-
-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changing the chompfile.toml while watching via chomp -w
does not invalidate
#92
Comments
I may have tested this incorrectly. My |
Changes to the Chompfile is quite tricky to support, because it means modifying the in-place task graph based on a chompfile diff. So we would effectively need to implement a diffing algorithm which can be translated from a diff on the chompfile into a diff on the task graph, and then also make allowance for irreconcilable diffs to cause a complete reload. Definitely agreed this would be a good goal, will leave this up to track. |
Would it be easier to exec/replace the running chomp process if the chompfile is modified?
Mar 14, 2022 10:29:47 PM Guy Bedford ***@***.***>:
… Changes to the Chompfile is quite tricky to support, because it means modifying the in-place task graph based on a chompfile diff. So we would effectively need to implement a diffing algorithm which can be translated from a diff on the chompfile into a diff on the task graph, and then also make allowance for irreconcilable diffs to cause a complete reload. Definitely agreed this would be a good goal, will leave this up to track.
—
Reply to this email directly, view it on GitHub[#92 (comment)], or unsubscribe[https://github.com/notifications/unsubscribe-auth/AAAABAPHKVT4H2G6UORFDOLVAAG3HANCNFSM5QW7LCYA].
Triage notifications on the go with GitHub Mobile for iOS[https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675] or Android[https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub].
You are receiving this because you authored the thread. [data:image/png;base64,iVBORw0KGgoAAAANSUhEUgAAADwAAAA8CAYAAAA6/NlyAAAAAXNSR0IArs4c6QAAAARzQklUCAgICHwIZIgAAAAkSURBVGiB7cExAQAAAMKg9U/taQmgAAAAAAAAAAAAAAAAAABuOHwAAW17XWMAAAAASUVORK5CYII=###24x24:true###][Tracking image][https://github.com/notifications/beacon/AAAABAPINLUFBZ4TE4F63IDVAAG3HA5CNFSM5QW7LCYKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOH6QY5CY.gif]
|
I don't think I've ever written anything to replace the current process with a new invocation of itself? I would need to do more careful book-keeping to multi-instance the application lifecycle unfortunately :( |
(but yes you are right that's the way to do it) |
I modified the chompfile while using
chomp -ws
and I was expecting it to re-build targets affected by the task whose options I modified:I added
whitespace = false
to the template-options, expectingindex.html
's import map to be formatted differently.The text was updated successfully, but these errors were encountered: