-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
The new version of BBHx has changed how shift_t_limits
work
#21
Comments
@WuShichao Can you make sure our tests are pinning a BBHx version while this is sorted out? |
They are ... well they're pinning a fork that isn't going to change https://github.com/gwastro/pycbc/blob/master/tox.ini#L74 |
@spxiwh I think the first step is to update the code to replicate the current references. It looks like one could just set t_ref to tc and appropriately set the other options to get essentially the same result. This may require some testing. |
I think that we already have t_ref=tc (I think this is the default), and t_ref_end is not used at all. So the only issue I see is with translating t_ref_start ... I guess this just becomes |
@spxiwh Thanks for reporting this issue. Actually, |
In the version of BBHx we have coded against we set the kwarg
shift_t_limits
to false. BBHX saysHowever, now this is deprecated, and is ignored ... It is always set to True. This then breaks the code as the times are nonsensical. I guess we can ignore
t_obs_end
if we are generating "full" waveforms, butt_obs_start
is not always trivial (and may cause waveforms to "wrap around"). Not really sure what behaviour we want here.The text was updated successfully, but these errors were encountered: