Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid repeated FAR/IFAR conversions #4487

Open
GarethCabournDavies opened this issue Sep 14, 2023 · 1 comment
Open

Avoid repeated FAR/IFAR conversions #4487

GarethCabournDavies opened this issue Sep 14, 2023 · 1 comment
Assignees

Comments

@GarethCabournDavies
Copy link
Contributor

Too many FAR/IFAR conversions means that numerical inaccuracy can creep in.

The fact that FAR is in Hz in some places and years^{-1} in others should be kept consistent throughout.

@tdent
Copy link
Contributor

tdent commented Sep 15, 2023

These are two separate questions, but maybe worth considering/fixing at the same time.

My initial thoughts on this are that IFAR is a nicer variable to use internally, as it's some number of seconds which in some cases (time slide limit, thresholding at some number of hours/days/years) can be a whole number.

For the units, it might be worth having them in variable names so that we can see what they are and spot bugs more easily .. eg fg_ifar_s / fg_ifar_yr

(except inside functions which don't care about units ..)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants