Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

timeslice needs better unittests and improved documentation. #4656

Open
ahnitz opened this issue Feb 28, 2024 · 0 comments
Open

timeslice needs better unittests and improved documentation. #4656

ahnitz opened this issue Feb 28, 2024 · 0 comments
Assignees

Comments

@ahnitz
Copy link
Member

ahnitz commented Feb 28, 2024

There's been a number of issues that are thought to be related to some indexing bugs in the time slice method. There are two things that would be useful to improve. (1) better unittests that cover some of the failure modes to prevent future regression. (2) some better documentation so the expected behavior is more.

#4655 may have fixed the most serious issue which was caused by a mistake in the indexing logic. This may be the cause of issues like #4643.

We should make sure that any unittest may be able to catch such cases.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants