Vetoes

[pannarale]

• In def load_triggers(input_file, vetoes): (pycbc/pycbc/results/pygrb_postprocessing_utils.py) the vetoes need to be implemented. There should be old (xml) code in PR PyGRB post-processing #3972. A rough scheme is

# =============================================================================
 # Veto trigger
 # =============================================================================
 def veto_trig(trigs, trial_dict):
    """Remove trigs that are not in trial dict"""
     mask = []
     for time in trigs['network/end_time_gc']:
        mask.append(any([time in trial for trial in trial_dict]))
     return {key: trigs[key][mask] for key in trigs.keys()}

but we are using hdf and not dictionaries so the last line needs updating.

• pycbc_multi_inspiral contains

[...]
from pycbc.vetoes import sgchisq
[...]
sgchisq.SingleDetSGChisq.insert_option_group(parser)
[...]

which does not do anything productive [we would need to call sg_chisq = sgchisq.SingleDetSGChisq.from_cli(opt, bank, opt.chisq_bins) and output `sg_chisq.values(...)]. Having said that, PyGRB uses banks with long templates (NSBH, BNS): we should simply remove this veto for short transients (BBHs with mass above $60 M_\odot$), but if one day anyone uses PyGRB with high-mass BBHs, then it would turn out to be a shortcoming.

[MarcoCusinato]

A bit more refined, and working, version of the function at the first point can be found here