Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Singularity support #150

Open
alecgunny opened this issue Dec 15, 2022 · 1 comment
Open

Singularity support #150

alecgunny opened this issue Dec 15, 2022 · 1 comment

Comments

@alecgunny
Copy link

When launching omicron jobs from a singularity container, the corresponding executable path will, in general, not exist in the environment in which the jobs get run. At a high level, it seems like this could be supported by:

  • introducing a --singularity-image (or similar) to the command line parser that defaults to os.getenv("SINGULARITY_CONTAINER"), which will be the full path to the running container's image if currently inside a container
  • Add a similar argument to OmicronProcessJob
  • During OmicronProcessJob.write_sub_file, check if self.singularity_image is not None, and if not add something like this to the sub file
f"""
+SingularityImage = "{self.singularity_image}"
Requirements = HasSingularity
"""
  • Longer term, the functionality from the point could even be worth upstreaming into glue.pipeline.CondorDAGJob.

If this is something the team thinks might be valuable, happy to take a stab at making a PR for this.

@alecgunny
Copy link
Author

Have a PR for this opened on our organization fork ML4GW#1, let me know if this is something you'd like me to open here as well

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant