-
Notifications
You must be signed in to change notification settings - Fork 88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
A part of the text is temporarily cleared while searching #533
Comments
The bug was introduced by commit 96f2bcd for |
That's the |
For what it's worth, I can't reproduce this on windows, with a (windows) terminal size of 80 columns and either 32 lines or 55 lines. I.e. after However, I can reproduce it on linux in xterm with size 80x32. |
Seems like there is a flush() missing somewhere. It needs to be called to write the buffered terminal data before a long pause, like in a search. This patch fixes it, but it may not be the best fix. I'll look into this some more.
|
search operation. Without this, buffered data may be not written or only partially written to the screen, so the screen could look inconsistent while the search operation is in progress. Related to #533.
Should be fixed in d67f5b0 in the post659 branch. |
With some terminal sizes, a part of the text is temporarily cleared while searching.
This bug reproducible with the
less
643-1 Debian/unstable package and withless
633 under Android/Termux.To reproduce:
>
to go to the end of the text.<
to go to the beginning of the text./z
then [Enter] to search for "z" (something that does not appear in the text).Result: During the search, a part of the text is cleared. For instance, with a 32-line terminal:
Note: the goal of the high number of lines in the full text is to ensure that the search takes enough time to make the issue appear. After "Pattern not found (press RETURN)" is output, the text is restored.
The text was updated successfully, but these errors were encountered: