Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Black line appears when use fit method #249

Closed
lastonoga opened this issue Feb 18, 2019 · 7 comments
Closed

Black line appears when use fit method #249

lastonoga opened this issue Feb 18, 2019 · 7 comments

Comments

@lastonoga
Copy link

Hi @Dynom ,

There is a problem again with image resize. (fit) #238

Original
y0gwdzc6e5df3vg3eywevhwl513ulx5mvddusn8m

Resized
jpeg-1

Url:
http://localhost/fit?width=100&height=3000&type=jpeg&url=/media/images/IGhus8SiKg5390WhTrrP6HWeK6Dz3zZLzC9ZHf7B.jpeg

@Dynom
Copy link
Collaborator

Dynom commented Feb 18, 2019

That's not good at all. However afaik there haven't been any changes since the fix to /fit in 1.1.18. What version are you on ?

@lastonoga
Copy link
Author

lastonoga commented Feb 18, 2019

@Dynom h2non/imaginary:1.0.18. Fix that you did, helped with most images, thanks.
But as you can see some of them have the line. Looks like some problem in algorithm's logic, not only numbers rounding.

@Dynom
Copy link
Collaborator

Dynom commented Feb 19, 2019

Alright, I'll look at it once I find the time 👍

@lastonoga
Copy link
Author

@Dynom Thanks!

@lastonoga
Copy link
Author

lastonoga commented Feb 20, 2019

I did a PR #250
I test it with that image and it helps, but i can't write normal test, because i don't know Go

@h2non
Copy link
Owner

h2non commented Jun 7, 2020

This should be fixed in v1.2.0. Closing for now.

@h2non h2non closed this as completed Jun 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants